Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit should default to 10K #61

Closed
jvshahid opened this issue Nov 15, 2013 · 6 comments
Closed

Limit should default to 10K #61

jvshahid opened this issue Nov 15, 2013 · 6 comments
Milestone

Comments

@jvshahid
Copy link
Contributor

Instead of defaulting the start time to now() - 1h, we should be limiting the number of points that are returned to the user, unless they explicitly set LIMIT 0. In which case the limit won't be set.

@FGRibreau
Copy link

+1 Cassandra does the same thing:

By default, a query returns 10,000 rows maximum. Using the LIMIT clause, you can change the default limit of 10,000 rows to a lesser or greater number of rows. The default is 10,000 rows.

@hvt
Copy link

hvt commented Dec 3, 2013

A followup on this, when I have a serie with > 10k events, and I issue the following query:

select count(column1) from test

I get back 10000. While:

select count(column1) from test limit 0

Gives indeed back the correct number of events.

I get this has to do with this issue. Although I believe this isn't preferable when using group-like functions, right?

@pauldix
Copy link
Member

pauldix commented Dec 3, 2013

Hmmm yes, you're probably right. We'll reopen and have the limit go away if you're using an aggregate function.

@jvshahid
Copy link
Contributor Author

I think for the time being we're going to get rid of the default limit. We are thinking about revisiting this issue later to have a database configuration for the maximum number of points a user can retrieve in a query. I'll close this issue with a commit in a little bit.

@pauldix
Copy link
Member

pauldix commented Jan 31, 2014

@pauldix pauldix reopened this Jan 31, 2014
@jvshahid
Copy link
Contributor Author

Fixed in 52fad8d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants