For writes to non replicated series the write should be synchronous #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like you're still writing to the WAL, which isn't necessary since the write is synchronous. I see that you added the |
|
Nice catch. That's fixed. |
Currently all writes (unless synchronous) have to go through the write buffer and the WAL in order to guarantee proper replication. This commit changes the behavior for shards that aren't replicated. Fix #734.
|
looks rad, do it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently all writes go through the WAL even for non replicated time series/database. We should skip the wal if the write is not to be replicated. In that case the write is synchronous and it can pass/fail.