Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misleading error trying to select from non-existent series #778

Merged
merged 1 commit into from
Oct 23, 2014

Conversation

jvshahid
Copy link
Contributor

graphite> select * from this-series-DEFINITELY-doesnt-exist
graphite> ✘ Error: Couldn't look up columns for series: this-series-DEFINITELY-doesnt-exist

error should be something like "series 'this-series-DEFINITELY-doesnt-exist' not found"

@jvshahid
Copy link
Contributor

duplicate of #1004

@jvshahid jvshahid closed this Oct 21, 2014
@Dieterbe
Copy link
Contributor Author

#1004 is about existing series that don't have data for the requested timeperiod.
this issue (#778) is about series that don't exist at all.

if i understand correctly, now if you select a series that doesn't exist you get an empty response, I think it would be better to return an error that the series doesn't exist at all.

jvshahid added a commit that referenced this pull request Oct 22, 2014
@jvshahid
Copy link
Contributor

That makes sense. Reopening

@jvshahid jvshahid reopened this Oct 22, 2014
@jvshahid jvshahid added bug and removed engine labels Oct 22, 2014
@jvshahid jvshahid self-assigned this Oct 22, 2014
@jvshahid
Copy link
Contributor

/cc @pauldix @toddboom are you guys fine with this change ?

@toddboom
Copy link
Contributor

@jvshahid In keeping with the current error message style, can we make it:

Couldn't find series: series-name-here

Or tell me it's fine as it is. ;)

@toddboom
Copy link
Contributor

Looks good. I'll merge as soon as Travis finishes.

toddboom added a commit that referenced this pull request Oct 23, 2014
misleading error trying to select from non-existent series
@toddboom toddboom merged commit 638db64 into master Oct 23, 2014
@toddboom toddboom removed the review label Oct 23, 2014
@jvshahid jvshahid deleted the issue-778 branch October 23, 2014 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants