Prevent blank database names #843
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -637,6 +637,16 @@ func (self *ApiSuite) TestCreateDatabase(c *C) { | |||
| c.Assert(self.coordinator.db, Equals, "foo") | |||
| } | |||
|
|
|||
| func (self *ApiSuite) TestCreateDatabaseFailures(c *C) { | |||
| data := []string{`{"name": ""}`, `{}`, `{"not_name": "bar"}`} | |||
There was a problem hiding this comment.
While in here I decided to test some other bad requests.
|
I pushed up a simple change to the patch, so a helpful message is returned to the user. A more comprehensive fix for this issue would be if you guys specified what is acceptable as a database name, and then I encode the spec as a regex check. [0-9a-zA-Z_-] could work, but perhaps you'd like to support a broader range of names. The same fundamental issue applies to usernames, passwords etc., I am guessing. That said, this change prevents basic mistakes during database creation. |
jvshahid
pushed a commit
that referenced
this pull request
Sep 24, 2014
This was referenced Oct 26, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent issue #812 from re-occurring.