Input plugin: collectd #992
Conversation
|
+1, it would be great to have such an option available natively ! collectd/collectd#696 also discusses what would be the best way to send collectd metrics to influxdb. What is nice with your work @kimor79 is that people running old collectd versions can just add a couple of lines to their configuration to start shipping data to influxdb. No need to patch/upgrade/rebuild collectd on those legacy systems. |
|
CLA submitted |
|
not sure, but FWIW in one of my other OSS projects if add-on packages become too much of a burden and no one fixes it within a reasonable time we just drop it until somebody steps up and puts things in good shape. It's just a matter of being upfront and clear about it. Granted said other project is a linux distro where packages come and go all the time, so it's a thing that people get used to. This case is a bit different. |
|
I'm also a bit hesitant because of the maintenance issue. However, if people want it we can always take it in and pull it out later if it gets into a state of disrepair? |
| case "value": | ||
| // Don't add to metric name | ||
| case "": | ||
| // Don't add to metric name |
There was a problem hiding this comment.
this could just be case "value", case "":
|
@kimor79 i think the consensus is to merge this in. I had few questions which are in the comments above. As soon as you clarify those points I'll be happy to merge the pr into master. |
|
Pushed a change so the series name is how collectd formats it and types.db is checked earlier. Let me know if any other changes need to be made. Thanks! |
| @@ -151,6 +156,28 @@ func (self *Server) ListenAndServe() error { | |||
| log.Info("Graphite input plugins is disabled") | |||
| } | |||
|
|
|||
| if self.Config.CollectdEnabled { | |||
| // Helper function to DRY out error log message | |||
| fail_reason := func(r string) string { | |||
There was a problem hiding this comment.
The go idiom is to use camel cased variable names instead of underscores, can you change this variable name
There was a problem hiding this comment.
Sure. That section was pretty much a copy of the graphite section (https://github.com/influxdb/influxdb/blob/eef53f722892d98fdf30f8320bbdc3c1c0ac49ab/server/server.go#L138)
| uts := (packet.TimeHR >> 30) * 1000 | ||
| // TimeHR is also uint64 but influx expects int64 | ||
| sts := strconv.FormatUint(uts, 10) | ||
| ts, _ := strconv.ParseInt(sts, 10, 64) |
There was a problem hiding this comment.
@kimor79 any reason why you ignore the error ?
There was a problem hiding this comment.
No particular reason. I can submit another patch if needed.
This plugin supports receiving metrics via collectd's "network" plugin. It parses the binary protocol and stores most metric data as columns. Values are all float64. It requires the types.db file to be on the influxdb system.
Feedback appreciated.