Wire up DROP MEASUREMENT #1698
Merged
Wire up DROP MEASUREMENT #1698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corylanou
force-pushed
the
drop-measurement
branch
3 times, most recently
from
6c57083
to
e0b3a19
Compare
|
LGTM |
| @@ -830,6 +830,195 @@ func TestServer_WriteSeries(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| // Ensure the server can drop a measurement. | |||
| func TestServer_DropMeasurement(t *testing.T) { | |||
There was a problem hiding this comment.
Add a unit test to ensure the the server does the right thing if the Measurement doesn't exist.
corylanou
force-pushed
the
drop-measurement
branch
from
c38f164
to
c7028e2
Compare
|
Thanks for clarifying comments @corylanou |
mark-rushakoff
pushed a commit
that referenced
this pull request
Jan 11, 2019
…wagger fix(ui/dataLoaders): Update cur_swagger for type safety in generated client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1695