Fix queries that return raw data without aggregates. #1704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bah, fixing test errors. Forgot to run the entire suite before commit. |
| s.CreateDatabase("foo") | ||
| s.CreateRetentionPolicy("foo", &influxdb.RetentionPolicy{Name: "raw", Duration: 1 * time.Hour}) | ||
| s.SetDefaultRetentionPolicy("foo", "raw") | ||
| s.CreateUser("susy", "pass", false) |
There was a problem hiding this comment.
FWIW, we don't need to create "susy". We should remove this from the other tests too.
|
Don't fully grok the rationale of some of these changes, but code looks reasonable. |
pauldix
force-pushed
the
fix-raw-ordering2
branch
from
15d5d95
to
450480d
Compare
| if err != nil { | ||
| return nil, err | ||
| } | ||
| stmt := e.stmt |
There was a problem hiding this comment.
To be clear, because you're only supporting 1 field for raw queries, I presume this is why Substatement is not being called.
There was a problem hiding this comment.
No, because for raw queries there's only a single map function. You can get 1, more, or all fields in a raw query.
|
Some feedback, none mandatory. +1 |
I also removed the engine test for the raw planner. It's getting tested elsewhere and it would have been too difficult to make it work. Besides, that's getting replaced soon anyway.
pauldix
force-pushed
the
fix-raw-ordering2
branch
from
450480d
to
db0f5f0
Compare
pauldix
added a commit
that referenced
this pull request
Feb 24, 2015
Fix queries that return raw data without aggregates.
mark-rushakoff
pushed a commit
that referenced
this pull request
Jan 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an ugly hack, but it'll have to do until I finish the query engine refactoring. Please to review @benbjohnson