Drop series failing Issue #1761 #1767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corylanou
force-pushed
the
drop-series-failing-1761
branch
from
e03886a
to
2a9306f
Compare
|
LGTM, |
corylanou
added a commit
that referenced
this pull request
Feb 27, 2015
Drop series failing Issue #1761
mark-rushakoff
pushed a commit
that referenced
this pull request
Jan 11, 2019
* Adjust proportions * Ensure contents don't touch the bottom of the viewport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1761
Drop series was failing when multiple shards exists from writing data across time boundaries for a retention policy.
Also uncovered that
SHOW SERIEScould return blank rows for measurements where all measurement series had been deleted. This has been fixed as well.Added some better error messages with context to assist in future debugging.
Enhanced a shell script test that allowed this bug to also be reproduced by hand.