Querying for missing measurements should return a 200 #1813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toddboom
changed the title
200 OK
|
This should also be true if the measurement doesn't have the field that the user is requesting. Basically, 500 responses should only be for actual server errors. And the only 400 response should be if the query didn't actually parse, or for unauthorized. |
pauldix
added a commit
that referenced
this pull request
Mar 3, 2015
Querying for missing measurements should return a 200
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, this returns a
500 Server Error. It should return a200 OKwith an error in the result set stating that the measurement name couldn't be found.