use map for marshaledTags cache #2136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -127,7 +127,7 @@ type dropMeasurementCommand struct { | |||
| type createMeasurementSubcommand struct { | |||
| Name string `json:"name"` | |||
| Tags []map[string]string `json:"tags"` | |||
| marshaledTags []string // local cache...don't marshal | |||
| marshaledTags map[string]struct{} // local cache...don't marshal | |||
There was a problem hiding this comment.
Style suggestion -- pull this field into its own section of the struct definition, separated by a newline from the exported fields.
|
Makes sense, should make a difference if the number of tags is large. |
|
Looks good to me +1. |
dgnorton
added a commit
that referenced
this pull request
Apr 1, 2015
use map for marshaledTags cache
mark-rushakoff
pushed a commit
that referenced
this pull request
Jan 11, 2019
chore(ci): Update schedule back to single nightly build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.