Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use map for marshaledTags cache #2136

Merged
merged 2 commits into from
Apr 1, 2015
Merged

use map for marshaledTags cache #2136

merged 2 commits into from
Apr 1, 2015

Conversation

dgnorton
Copy link
Contributor

@dgnorton dgnorton commented Apr 1, 2015

No description provided.

@@ -127,7 +127,7 @@ type dropMeasurementCommand struct {
type createMeasurementSubcommand struct {
Name string `json:"name"`
Tags []map[string]string `json:"tags"`
marshaledTags []string // local cache...don't marshal
marshaledTags map[string]struct{} // local cache...don't marshal
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style suggestion -- pull this field into its own section of the struct definition, separated by a newline from the exported fields.

@otoolep
Copy link
Contributor

otoolep commented Apr 1, 2015

Makes sense, should make a difference if the number of tags is large.

@otoolep
Copy link
Contributor

otoolep commented Apr 1, 2015

Looks good to me +1.

dgnorton added a commit that referenced this pull request Apr 1, 2015
@dgnorton dgnorton merged commit ab62c5b into master Apr 1, 2015
@dgnorton dgnorton deleted the more_write_performance branch April 1, 2015 05:01
mark-rushakoff pushed a commit that referenced this pull request Jan 11, 2019
chore(ci): Update schedule back to single nightly build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants