Mean and percentile function fixes #2404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwilder
added a commit
that referenced
this pull request
Apr 23, 2015
…orted value: NaN If the MapMean did not have any values in the iterator, it would return and empty meanMapOutput(). ReduceMean would in turn divider the results by an unitialized float64 producing a NaN. NaN is not serializable to JSON by default.
|
👍 |
jwilder
added a commit
that referenced
this pull request
Apr 23, 2015
Mean and percentile function fixes
| @@ -1456,9 +1456,7 @@ func TestSingleServerDiags(t *testing.T) { | |||
| t.Skip(fmt.Sprintf("skipping '%s'", testName)) | |||
| } | |||
| dir := tempfile() | |||
| defer func() { | |||
There was a problem hiding this comment.
I think go lint will complain about these changes. Not sure, but I think so. We don't run lint right now, so perhaps it doesn't matter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #2374 which had two panics related to percentiles. It also fixes a JSON marshaling exception when
NaNis returned from a mean function.