Implement tag support in SELECT statements #2598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toddboom
force-pushed
the
select-tag-keys
branch
2 times, most recently
from
f5d89d4
to
5eaec30
Compare
| expected: `{"results":[{"series":[{"name":"cpu","columns":["time","value"],"values":[["2015-02-28T01:03:36.703820946Z",100]]}]},{"series":[{"name":"cpu","columns":["time","value"],"values":[["2015-02-28T01:03:36.703820946Z",100]]}]}]}`, | ||
| name: "selecting a tag and a field", | ||
| query: `SELECT host, value FROM "%DB%"."%RP%".gpu`, | ||
| expected: `{"results":[{"series":[{"name":"gpu","tags":{"host":"server01"},"columns":["time","value"],"values":[["2015-02-28T01:03:36.703820946Z",100]]}]}]}`, |
There was a problem hiding this comment.
Can you update this test so it has two data points from different hosts?
|
+1 |
| // since selectNames can contain tags, we need to strip them out | ||
| selectFields := make([]string, 0, len(selectNames)) | ||
|
|
||
| for _, n := range selectNames { |
There was a problem hiding this comment.
I think you can shorten this to:
for _, n := range selectNames {
if _, found := m.TagSet.Tags[n]; !found {
selectFields = append(selectFields, n)
}
} There was a problem hiding this comment.
yes, plz! doing it now.
|
Minor feedback, looks great. +1 |
toddboom
added a commit
that referenced
this pull request
May 20, 2015
Implement tag support in SELECT statements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1989 and #2499.