Return empty result set if database not present in shard data #2865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otoolep
force-pushed
the
db_not_found_no_data
branch
from
5f73dfb
to
68ecfd0
Compare
|
Note - I am not quite sure about the test cases, if this approach looks correct, I can dig more into what would be the correct way to unit test this. |
|
I think that makes sense. Would love to have some integration tests for this but I don't think we are ready to create those scenarios yet. +1 |
|
agree that empty response is more suitable than database not found (presuming that something higher up has verified that a database does exist) |
otoolep
force-pushed
the
db_not_found_no_data
branch
from
68ecfd0
to
8539322
Compare
otoolep
force-pushed
the
db_not_found_no_data
branch
from
8539322
to
b65396e
Compare
|
Implicit +1 from @pauldix |
otoolep
added a commit
that referenced
this pull request
Jun 11, 2015
Return empty result set if database not present in shard data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for #2851
The idea here is that the upper layers should check if a particular database exists. If those checks pass, the query gets to the shard data, but the database does not exist there, it's because no data has been written for that database to the shard. So just return an empty set.