Re-enable server reporting #2904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yeah, this looks awesome. much simpler than what i had started. |
|
Yeah, I think a |
otoolep
force-pushed
the
reporter_service
branch
from
b7a667a
to
bcf4bf0
Compare
| @@ -46,6 +46,15 @@ func (d *DatabaseIndex) Measurement(name string) *Measurement { | |||
| return d.measurements[name] | |||
| } | |||
|
|
|||
| // MeasurementSeriesCounts returns the number of measurments and series currently indexed by the database. | |||
| // Useful for reporting and monitoring. | |||
| func (d *DatabaseIndex) MeasurementSeriesCounts() (nMeasurements int, nSeries int) { | |||
There was a problem hiding this comment.
Named return values, for self-documentation purposes.
|
+1 |
otoolep
force-pushed
the
reporter_service
branch
2 times, most recently
from
d7c1692
to
2b5e7f4
Compare
|
LGTM 🚢 |
otoolep
force-pushed
the
reporter_service
branch
from
2b5e7f4
to
923556d
Compare
otoolep
force-pushed
the
reporter_service
branch
from
923556d
to
9681f4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.