Force all values to float64 for math #3611
Conversation
otoolep
force-pushed
the
integer_math
branch
3 times, most recently
from
2e98868
to
5e3cbec
Compare
otoolep
changed the title
Any literal values in a math query e.g. the '2' in 'value * 2' are stored as float64, so all other values must be cast to this type. This does mean that precision may be lost if the integer values are greater than 2^53.
|
Wouldn't it be better to fix it so that if the field is an int we use int instead of float? |
|
@pauldix - as explained in the commit, the parser stores the literal numbers in the math as float64. So the query Does this answer your question? |
|
There is something up with Circle and the git history -- it can't check out the code. I have created an identical PR here: |
|
Yeah, I'm suggesting that we actually fix it so that it will do the right math on the given type. Guess this will work for a quick fix, but we should open up an issue to fix this later. |
|
#3614 opened to track parsing the mathematical literals correctly. |
Fixes issue #3000
Any literal values in a math query e.g. the '2' in 'value * 2' are stored as float64 by the parser, so all other values must be cast to this type. This does mean that precision may be lost if the integer values are greater than 2^53.