Exponential hinted-handoff interval on fail #4284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Discussed this with @jwilder, and it's actually not too bad because when a node comes online, it will get all its data in one shot. |
[ci skip]
| @@ -119,17 +119,26 @@ func (s *Service) WriteShard(shardID, ownerID uint64, points []models.Point) err | |||
|
|
|||
| func (s *Service) retryWrites() { | |||
| defer s.wg.Done() | |||
| ticker := time.NewTicker(time.Duration(s.cfg.RetryInterval)) | |||
| defer ticker.Stop() | |||
| currInterval := time.Duration(s.cfg.RetryInterval) | |||
There was a problem hiding this comment.
Should probably clamp the initial retry interval down to the Max as well here in case someone happened to misconfigure it. e.g. they set a retry-interval = 5m but retry-max-interval = 1m. The first retry would wait 5m but subsequent ones would wait 1m.
|
One small thing but otherwise 👍 |
This could happen due to misconfiguration, so do something sensible in that case.
|
Thanks @jwilder -- made that change, will merge on green. |
otoolep
added a commit
that referenced
this pull request
Oct 1, 2015
Exponential hinted-handoff interval on fail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change has the hinted handoff service backoff exponentially if any hinted handoff write fails.
This is not ideal since hinted handoff may be writing to many nodes, some of which have come back online. This change means that all nodes will be written to slowly if any node is down. It may be better to have a separate goroutine for each node that is due to receive data, so nodes that are up get the data as quickly as possible, and the backoff only applies to downed nodes.