Add public function to graphite parser to apply template #4348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sparrc
force-pushed
the
graphite-apply-template
branch
from
deda4d3
to
5b7c158
Compare
| @@ -50,7 +50,9 @@ func NewParserWithOptions(options Options) (*Parser, error) { | |||
| filter := "" | |||
| // Format is [filter] <template> [tag1=value1,tag2=value2] | |||
| parts := strings.Fields(pattern) | |||
| if len(parts) >= 2 { | |||
| if len(parts) < 1 { | |||
| continue | |||
There was a problem hiding this comment.
yep, it panic'ed if the user supplied an empty string template, which I found out completely on accident
|
+1, assuming the case I asked about is handled. |
|
Good question, I'll add a test to verify that it doesn't do anything to the measurement name if it doesn't match. |
sparrc
force-pushed
the
graphite-apply-template
branch
from
5b7c158
to
35b8b2b
Compare
|
closed by 883d32c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to support the Telegraf statsd plugin, where I want to provide templating for statsd/graphite-style buckets -> influxdb info.
For Telegraf I don't want the full point parsing (
Parser.Parse), I only want to parse the measurement name and tags.