check for cloud licensing and infoblox-go-client version to v0.3.0 #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmayb
approved these changes
Mar 12, 2018
jkraj
reviewed
Mar 13, 2018
README.md
Outdated
| @@ -13,7 +13,8 @@ Infoblox docker-ipam-plugin is Docker Certified IPAM Plugin and is available at | |||
|
|
|||
| To use the driver, you need access to the Infoblox DDI product. For evaluation purposes, you can download a | |||
| virtual version of the product from the Infoblox Download Center (https://www.infoblox.com/infoblox-download-center) | |||
| Alternatively, if you are an existing Infoblox customer, you can download it from the support site. | |||
| Alternatively, if you are an existing Infoblox customer, you can download it from the support site and must be applied with | |||
| cloud automation licensing from the CLI using ```set temp_license```. | |||
There was a problem hiding this comment.
Do the similar changes I requested in other ReadMe
jkraj
reviewed
Mar 13, 2018
| @@ -51,7 +51,7 @@ imports: | |||
| subpackages: | |||
| - netlabel | |||
| - name: github.com/infobloxopen/infoblox-go-client | |||
| version: e3afa79f174f4ef5932d24c97d69fdf6569bd3c5 | |||
| version: v0.3.0 | |||
There was a problem hiding this comment.
you should not change this file actually? I have a doubt now Did you tested this changes?
There was a problem hiding this comment.
I only compiled and built all the go files I did not get any error..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.