Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'name' field added in Fixedaddress struct #69

Merged
merged 1 commit into from
May 30, 2018
Merged

'name' field added in Fixedaddress struct #69

merged 1 commit into from
May 30, 2018

Conversation

AjeyHiremath
Copy link
Contributor

added field ‘name’ in return_field slice of Fixedaddress struct

@chinmayb chinmayb requested a review from yuewko May 26, 2018 11:14
@chinmayb chinmayb mentioned this pull request May 26, 2018
Closed
@chinmayb
Copy link
Contributor

chinmayb commented May 26, 2018 •
edited
Loading

Can you also add "ipv4addr" to host record
#59.
Since both are regressions, we can fix in this commit.

@yuewko
Copy link
Contributor

yuewko commented May 26, 2018

#69 (comment)

Can you also add "ipv4addr" to host record
#59.
Since both are regressions, we can fix in this commit.

It would be better to have a separate commit for #59, since #62 that this PR fixes is very much independent.

@yuewko
Copy link
Contributor

yuewko commented May 26, 2018

Please make sure CI passes.

@AjeyHiremath AjeyHiremath reopened this May 28, 2018
@AjeyHiremath
Copy link
Contributor Author

@yuewko

yuewko
yuewko approved these changes May 30, 2018
View reviewed changes
Copy link
Contributor

@yuewko yuewko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chinmayb chinmayb merged commit e0cd7be into infobloxopen:master May 30, 2018
@eest eest mentioned this pull request May 31, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuewko yuewko yuewko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AjeyHiremath @chinmayb @yuewko