make build fails

[NickLarsenNZ]

When I run the steps as outlined in the README, the build fails on a vendored dependency:

~/go/src/github.com/infobloxopen/terraform-provider-infoblox master$ make build
Doing dep ensure
cannot Stat: stat /home/user/go/src/github.com/infobloxopen/terraform-provider-infoblox/vendor/github.com/hashicorp/go-getter/test-fixtures/detect-file-symlink-pwd/syml/pwd: no such file or directory
GNUmakefile:13: recipe for target 'deps' failed
make: *** [deps] Error 1

I notice that pwd is a symlink to a non existant file in the directory above:

~/go/src/github.com/infobloxopen/terraform-provider-infoblox master$ ls -al vendor/github.com/hashicorp/go-getter/test-fixtures/detect-file-symlink-pwd/syml/pwd
lrwxrwxrwx 1 user user 7 Jul 29 16:22 vendor/github.com/hashicorp/go-getter/test-fixtures/detect-file-symlink-pwd/syml/pwd -> ../real

To get around it, I do the following:

touch vendor/github.com/hashicorp/go-getter/test-fixtures/detect-file-symlink-pwd/real

Finally:

~/go/src/github.com/infobloxopen/terraform-provider-infoblox master$ make build
==> Checking that code complies with gofmt requirements...
go install
go build -o terraform-provider-infoblox

I think by tagging and producing release artifacts using CI/CD as discussed in #33, users will not be tripped up by this. I also think by moving away from vendoring (to go modules), the problem will disappear, the repo will be smaller, and the dependency download process will be much faster.

[saiprasannasastry]

hi , will try to incorporate the comments, this might take some time. right now we have no preferred CI tool, will have to go through both and investigate

[saiprasannasastry]

@NickLarsenNZ like you were saying in previous issue , if you could raise a PR that would help us as well

[somashekhar]

Can you once check on the issue ? As of now we see build is successful.