This commit contains a new resource IPAssociation #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkraj
reviewed
Apr 24, 2018
| Type: schema.TypeString, | ||
| Required: true, | ||
| DefaultFunc: schema.EnvDefaultFunc("net_address", nil), | ||
| Description: "Give the address in cidr format.", |
There was a problem hiding this comment.
Network block/subnet in cidr format
jkraj
reviewed
Apr 24, 2018
| Type: schema.TypeString, | ||
| Optional: true, | ||
| DefaultFunc: schema.EnvDefaultFunc("macaddr", nil), | ||
| Description: "mac address of your instance in cloud.", |
There was a problem hiding this comment.
instance => virtual machine,
Either use Virtual Machine or instance.
jkraj
reviewed
Apr 24, 2018
infoblox/resourceIPAssociation.go
Outdated
| Type: schema.TypeString, | ||
| Optional: true, | ||
| DefaultFunc: schema.EnvDefaultFunc("vmid", nil), | ||
| Description: "Virtual Machine name.", |
There was a problem hiding this comment.
Either use Virtual Machine or instance.
jkraj
reviewed
Apr 24, 2018
infoblox/resourceIPAssociation.go
Outdated
| Type: schema.TypeString, | ||
| Required: true, | ||
| DefaultFunc: schema.EnvDefaultFunc("tenant_id", nil), | ||
| Description: "Unique identifier of your instance in cloud.", |
There was a problem hiding this comment.
Unique identifier of your tenant in cloud
jkraj
reviewed
Apr 24, 2018
| connector := m.(*ibclient.Connector) | ||
|
|
||
| objMgr := ibclient.NewObjectManager(connector, "terraform", tenantID) | ||
|
|
There was a problem hiding this comment.
add detailed comment about logic here
jkraj
reviewed
Apr 24, 2018
| connector := m.(*ibclient.Connector) | ||
|
|
||
| objMgr := ibclient.NewObjectManager(connector, "terraform", tenantID) | ||
|
|
There was a problem hiding this comment.
add detailed comment about logic here
jkraj
reviewed
Apr 24, 2018
infoblox/resourceIPAllocation.go
Outdated
| tenantID := d.Get("tenant_id").(string) | ||
| connector := m.(*ibclient.Connector) | ||
|
|
||
| objMgr := ibclient.NewObjectManager(connector, "terraform", tenantID) | ||
|
|
||
| _, err := objMgr.ReleaseIP(networkViewName, cidr, ipAddr, macAddr) | ||
| _, err := objMgr.DeleteHostRecord(d.Id()) | ||
| if err != nil { | ||
| return fmt.Errorf("Error Releasing IP from network(%s): %s", cidr, err) |
There was a problem hiding this comment.
use ref instead of cidr which have all the details like n/w view + n/w etc
jkraj
reviewed
Apr 24, 2018
| connector := m.(*ibclient.Connector) | ||
|
|
||
| objMgr := ibclient.NewObjectManager(connector, "terraform", tenantID) | ||
|
|
||
| _, err := objMgr.GetFixedAddress(networkViewName, cidr, ipAddr, macAddr) | ||
| _, err := objMgr.GetHostRecord(d.Id()) | ||
| if err != nil { | ||
| return fmt.Errorf("Error getting IP from network block(%s): %s", cidr, err) |
There was a problem hiding this comment.
use ref instead of cidr which have all the details like n/w view + n/w etc
use network block or network everywhere
jkraj
reviewed
Apr 24, 2018
| connector := m.(*ibclient.Connector) | ||
|
|
||
| objMgr := ibclient.NewObjectManager(connector, "terraform", tenantID) | ||
|
|
||
| _, err := objMgr.GetFixedAddress(networkViewName, cidr, ipAddr, macAddr) | ||
| _, err := objMgr.GetHostRecord(d.Id()) |
There was a problem hiding this comment.
Need a short description why we are using host record rather than fixed address.
This commit also contains changes in the way IP gets assigned. Previously the IP assigned was of type fixedaddress now it has become host address Necessary changes in other resources have been made to allocate host address
jkraj
approved these changes
Apr 24, 2018
AvRajath
added a commit
that referenced
this pull request
Dec 16, 2020
…network_branch Adding DataSource for Network
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit also contains changes in the way IP gets assigned.
Previously the IP assigned was of type fixedaddress
now it has become host address
Necessary changes in other resources have been made
to allocate host address