Delete Network View fix issue #57 #73
Conversation
This fix requires a newer version of infoblox-go-client is released with infobloxopen/infoblox-go-client#92 The fix is not a good one. This resource stores name for the id unlike all the other resources which use Ref off the Struct in the go client. Changing it now would disrupt statefiles. Either we live with the computed network_view_ref attribute, see if it is possible to transition the state, or we need to deprecate this attribute in a future API release.
|
@pearcec thanks for your contribution. Your PR has been accepted on infoblox-go-client. So can you please update the vendor with the new release? |
|
I am happy to do it. But are you happy with the network_view_ref option? I think this resource should be rebuilt at some point. The implementation is inconsistent with the rest of the resources I reviewed. |
There is a lot of vendor baggage happening. Seems like go mod vendor has not been run in previous releases. Also updated the GNUmakefile to include the variables for build automatically updated README.md to reflect change.
|
Updated, see the commit message there is some vendor baggage that was cleaned up during the go mod vendor call I had to make. |
This may not be the best way to do it. But i guess it works for now. Might need to find a better way on using the _ref. |
This fix requires a newer version of infoblox-go-client is released
with infobloxopen/infoblox-go-client#92
The fix is not a good one. This resource stores name for the id
unlike all the other resources which use Ref off the Struct in the
go client. Changing it now would disrupt statefiles. Either
we live with the computed network_view_ref attribute, see if it
is possible to transition the state, or we need to deprecate this
attribute in a future API release.
#57