Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that parent exists before network allocation. #83

Conversation

AliaksandrDziarkach
Copy link

NIOS convert parent network to network container when network
inserted into network.
After such convertion caused parent network ID changed to network
container ID, so parent will be unavailable to terraform.
To prevent it - add check that parent is network container before
network allocation.

NIOS convert parent network to network container when network
inserted into network.
After such convertion caused parent network ID changed to network
container ID, so parent will be unavailable to terraform.
To prevent it - add check that parent is network container before
network allocation.
@somashekhar
Copy link
Contributor

There is a check for network container but what if there is a parent network under which the user will be creating a subnet.?
It would be better to check for both network container and the network as the parent network gets converted into a network container when we allocate next available network from that subnet.

Can we also use get "GetNetwork" to validate the same ?

@AliaksandrDziarkach
Copy link
Author

If parent CIDR points to the network - this network will be converted to the network container by NIOS code, as result parent ID will be changed which will cause errors in terraform when access this network.

@somashekhar
Copy link
Contributor

We would need a container ID to be tracked for subsequent terraform operations. Hence the present implementation looks good to me.

@somashekhar somashekhar merged commit 32dfff7 into infobloxopen:master Jan 25, 2021
@somashekhar
Copy link
Contributor

#27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants