Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some smal things #5

Merged
merged 1 commit into from
May 22, 2017
Merged

fix some smal things #5

merged 1 commit into from
May 22, 2017

Conversation

zero-24
Copy link

@zero-24 zero-24 commented May 21, 2017

Pull Request for Issue # .

Summary of Changes

Testing Instructions

Expected result

Actual result

Documentation Changes Required

@@ -16,7 +16,7 @@
/**
* Weblink HTML helper class.
*
* @since 1.6
* @since __DELPOY_VERSION__
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DEPLOY I guess :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

opps can you fix it?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or shoud i do a seccond PR?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@infograf768 infograf768 merged commit da554cb into infograf768:weblinks_assoc May 22, 2017
@zero-24 zero-24 deleted the weblinks_assoc branch May 22, 2017 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants