New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/update checkbox #40
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-haensch
approved these changes
Oct 19, 2020
Done quick QA on the netlify deployed storybook https://5f8d454d4c3d0c5f820ffdaf--sapera-storybook.netlify.app/?path=/story/checkbox--default looks working to me |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR updates the checkbox component so it's ready for use in the sapera-website forms.
required
, andhasError
, improve a11y, and optionally display error messagethin
will not exist as a border option in sapera-website, although it currently exists. It is not used anymore in this repo since it's being phased out)Can QA sapera-components locally and test by clicking on the checkboxes in
Checkbox
storyThis PR can optionally be tested in the
sapera-website
footer newsletter subscription in a related PR (WIP) https://github.com/infographicsgroup/sapera-website/pull/426 by usingyarn link
Before
After
Example use in sapera-website
Technical
util
Ticket
Related: