Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datagrid: Adding a multiselect dropdown in datagrid makes the checkbox overlap with text #1075

Closed
dmolinaj opened this issue Jul 8, 2021 · 3 comments · Fixed by infor-design/enterprise#5524 or infor-design/enterprise#5560
Assignees
Labels
type: bug 🐛 [2] Velocity rating (Fibonacci)

Comments

@dmolinaj
Copy link

dmolinaj commented Jul 8, 2021

Describe the bug
When adding a Soho.Formatters.Dropdown in a datagrid column and setting the editoroption multiple to true the checkbox overlaps with the text.

To Reproduce

  1. Open datagrid-angular-editor.demo.ts
  2. Add the code below in EDITORS_COLUMNS
    { id: "multiDropDown", name: "Multiple DropDown", field: "multiDropDown", formatter: Soho.Formatters.Dropdown, editor: Soho.Editors.Dropdown, editorOptions: { multiple: true, closeOnSelect: false, }, options: [ { label: "", value: "" }, { label: "On Hold", value: "oh" }, { label: "Shipped", value: "sh" }, { label: "Action", value: "ac" }, ], },
  3. Run the app and open Datagrid Angular Editors and see the text overlapping with the checkbox, also selecting an entry is not being retained.

Expected behavior
The text should have a space before the checkbox. The selected entries should be retinained.

Version

  • ids-enterprise-ng: v10.1

Screenshots
image

@tmcconechy tmcconechy added [2] Velocity rating (Fibonacci) type: bug 🐛 labels Jul 8, 2021
@tmcconechy tmcconechy changed the title Adding a multiselect dropdown in datagrid makes the checkbox overlap with text Datagrid: Adding a multiselect dropdown in datagrid makes the checkbox overlap with text Jul 8, 2021
@tmcconechy tmcconechy added this to To do in Enterprise 4.55.x (Aug 2021) Sprint via automation Jul 29, 2021
@ericangeles ericangeles moved this from To do to In progress in Enterprise 4.55.x (Aug 2021) Sprint Aug 16, 2021
@ericangeles ericangeles moved this from In progress to Pending Review in Enterprise 4.55.x (Aug 2021) Sprint Aug 17, 2021
@tmcconechy tmcconechy moved this from Pending Review to Ready for QA (beta) in Enterprise 4.55.x (Aug 2021) Sprint Aug 26, 2021
@jbrcna
Copy link

jbrcna commented Aug 27, 2021

QA Failed. switch to different(smaller) row heights. checkbox will overlap.
v4.55.0-dev
verified in https://main-enterprise.demo.design.infor.com/components/datagrid/test-multi-select-dropdown-selection.html
image

@jbrcna jbrcna moved this from Ready for QA (beta) to Done in Enterprise 4.55.x (Aug 2021) Sprint Aug 27, 2021
@ericangeles
Copy link
Contributor

@jbrcna good catch

@ericangeles ericangeles moved this from Done to In progress in Enterprise 4.55.x (Aug 2021) Sprint Aug 27, 2021
@tmcconechy tmcconechy moved this from In progress to Pending Review in Enterprise 4.55.x (Aug 2021) Sprint Aug 27, 2021
@tmcconechy tmcconechy moved this from Pending Review to Ready for QA (beta) in Enterprise 4.55.x (Aug 2021) Sprint Sep 2, 2021
@jbrcna
Copy link

jbrcna commented Sep 3, 2021

this issue is now resolved. Thank you.
v4.55.0-dev
image

@jbrcna jbrcna moved this from Ready for QA (beta) to Done in Enterprise 4.55.x (Aug 2021) Sprint Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 [2] Velocity rating (Fibonacci)
Projects
No open projects
4 participants