Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About dialog: missing beforeOpen/close/afterClose events #1124

Closed
ahnpnl opened this issue Sep 8, 2021 · 2 comments · Fixed by infor-design/enterprise#6085 or #1226
Closed

About dialog: missing beforeOpen/close/afterClose events #1124

ahnpnl opened this issue Sep 8, 2021 · 2 comments · Fixed by infor-design/enterprise#6085 or #1226
Assignees
Labels
type: bug 🐛 [2] Velocity rating (Fibonacci)

Comments

@ahnpnl
Copy link
Contributor

ahnpnl commented Sep 8, 2021

Describe the bug

Currently the SohoAboutRef doesn't have beforeOpen/close/afterClose events while https://design.infor.com/code/ids-enterprise/latest/about mentions there should be.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://design.infor.com/code/ids-enterprise/latest/about and check Events section
  2. Go to https://github.com/infor-design/enterprise-ng/blob/main/projects/ids-enterprise-ng/src/lib/about/soho-about.ref.ts and read through the file but cannot find beforeOpen/close/afterClose events

Expected behavior
There should be beforeOpen/close/afterClose events, similar to https://github.com/infor-design/enterprise-ng/blob/main/projects/ids-enterprise-ng/src/lib/message/soho-message.ref.ts#L230

Version

  • ids-enterprise-ng: latest

Screenshots
N.A.

Platform

  • Device (if applicable) N.A.
  • OS Version: N.A.
  • Browser Name N.A.
  • Browser Version N.A.

Additional context
N.A.

@tmcconechy tmcconechy added [2] Velocity rating (Fibonacci) type: bug 🐛 labels Sep 8, 2021
@tmcconechy
Copy link
Member

The events are on the underlying modal. We might need to expose them both in the about component and in the NG wrapper.

@tmcconechy tmcconechy added this to Triage in Enterprise (Next) Sprint Grooming via automation Sep 8, 2021
@tmcconechy tmcconechy moved this from Triage to Ready For Dev in Enterprise (Next) Sprint Grooming Sep 10, 2021
@tmcconechy tmcconechy moved this from Ready For Dev to Check Back in Enterprise (Next) Sprint Grooming Sep 29, 2021
@tmcconechy tmcconechy moved this from Check Back to Triage in Enterprise (Next) Sprint Grooming Jan 6, 2022
@tmcconechy tmcconechy added this to To do in Enterprise 4.60.x (Jan 2022) Sprint via automation Jan 6, 2022
@ericangeles ericangeles self-assigned this Jan 7, 2022
@ericangeles ericangeles moved this from To do to In progress in Enterprise 4.60.x (Jan 2022) Sprint Jan 12, 2022
@tmcconechy tmcconechy moved this from In progress to Pending Review in Enterprise 4.60.x (Jan 2022) Sprint Feb 2, 2022
@CindyMercadoReyes CindyMercadoReyes moved this from Pending Review to Ready for QA (beta) in Enterprise 4.60.x (Jan 2022) Sprint Feb 4, 2022
@CindyMercadoReyes
Copy link

This issue is now resolved.

@CindyMercadoReyes CindyMercadoReyes moved this from Ready for QA (beta) to Done in Enterprise 4.60.x (Jan 2022) Sprint Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 [2] Velocity rating (Fibonacci)
Projects
No open projects
5 participants