Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab contents remain disabled when switching tabs in Contextual Action Panel #1210

Closed
lbursey-infor opened this issue Jan 13, 2022 · 11 comments · Fixed by infor-design/enterprise#6034

Comments

@lbursey-infor
Copy link

Describe the bug
Tab contents remain disabled when switching tabs in Contextual Action Panel

To Reproduce
Steps to reproduce the behavior:

  1. Add button, input, etc. to a soho-tab-panel inside of a Contextual Action Panel (not the panel open by default)
  2. Open the panel
  3. See that button, input, etc. remains disabled

Expected behavior
Disabled elements enabled when their tab is active

Version

  • ids-enterprise-ng: 13.0.x, 13.1.

Screenshots
image.

Platform

  • OS Version: Windows 10
  • Browser Name: Chrome, Firefox
@tmcconechy
Copy link
Member

@lbursey-infor do you have the code for what you tested you could add (or a stackblitz) - this would save a lot of time. Thanks

@tmcconechy tmcconechy added [3] Velocity rating (Fibonacci) type: bug 🐛 labels Jan 14, 2022
@lbursey-infor
Copy link
Author

Hi @tmcconechy , the file contextual-action-panel-tabs-vertical.component.html can be replaced with the following:

<div soho-tabs vertical="true" (activated)="onTabActivated($event)">
  <div soho-tab-list-container [verticalScrolling]="true">
    <ul soho-tab-list>
      <li soho-tab><a soho-tab-title tabId="tabs-vertical-1">Test Information</a></li>
      <li soho-tab selected="true"><a soho-tab-title tabId="tabs-vertical-2">Contacts</a></li>
    </ul>
  </div>
</div>

<div soho-tab-panel-container [verticalScrolling]="true">
  <div soho-tab-panel tabId="tabs-vertical-1">
    <input soho-toolbar-flex-searchfield [collapsible]="true" [clearable]="true" />
    <button type="button"  class="btn-primary">
      <span>Test</span>
    </button>
  </div>
  <div soho-tab-panel tabId="tabs-vertical-2">
  </div>
</div>

@lbursey-infor
Copy link
Author

lbursey-infor commented Jan 14, 2022

@tmcconechy FYI, this is blocking core functionality for WFM and will be a release blocker for our CU code cutoff on Jan 25th

@tmcconechy tmcconechy added the team: WFM For WFM Issues label Jan 14, 2022
@tmcconechy
Copy link
Member

Did this work in the past and broke? I’ll do a quick investigation next week

@tmcconechy tmcconechy added this to Triage in Enterprise (Next) Sprint Grooming via automation Jan 14, 2022
@lbursey-infor
Copy link
Author

lbursey-infor commented Jan 14, 2022

@tmcconechy This did work at one point yes. It worked at least as late as 10.3.0

@tmcconechy
Copy link
Member

tmcconechy commented Jan 14, 2022

Double assigning this in case @ericangeles can look before me but if not I will debug more next Tuesday

@ericangeles
Copy link
Contributor

@tmcconechy it looks like an EP issue. I was able to replicate it in EP.

@tmcconechy
Copy link
Member

@lbursey-infor this issue is fixed now. Would you need a patch? If so you have three choices:

  1. Wait for 13.1.0 in early feb
  2. On top of 13.0.1 as 13.0.2 (NG 13)
  3. On top of 10.12.0 as 10.13.0 (NG 12)

@lbursey-infor
Copy link
Author

@tmcconechy A patch for 13.0.x would be appreciated. Thanks for the quick turnaround!

@tmcconechy
Copy link
Member

Ok Its done 13.0.2 -> https://www.npmjs.com/package/ids-enterprise-ng/v/13.0.2

@CindyMercadoReyes CindyMercadoReyes moved this from Pending Review to Ready for QA (beta) in Enterprise 4.60.x (Jan 2022) Sprint Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants