Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAP: cssClass not added to modal element #1215

Closed
whernebrink opened this issue Jan 19, 2022 · 2 comments · Fixed by infor-design/enterprise#6146, #1242, infor-design/enterprise#6164 or #1250
Closed
Assignees
Labels
team: m3 Issues for m3 type: bug 🐛 [3] Velocity rating (Fibonacci)

Comments

@whernebrink
Copy link
Collaborator

whernebrink commented Jan 19, 2022

Describe the bug
Not able to apply cssClass to CAP modal.

To Reproduce
Steps to reproduce the behavior:

  1. Go to this this stackblitz

  2. Click on the "Show Cap Dialog" button

  3. Inspect the DOM

  4. You will see that there is no added class to the element:
    image

  5. Close the modal and click the "Open Standard Soho Modal"

  6. Inspect the DOM and you will see the added class name:
    image

Expected behavior
Using the .cssClass('my-custom-class') or .modalSettings({ cssClass: 'my-custom-class'}) should be applied to the element with the .modal class.

Version

  • ids-enterprise-ng: 13.0.0

Platform

  • OS Version: Mac OSX
  • Browser Name: n/a
  • Browser Version n/a
@tmcconechy tmcconechy added [3] Velocity rating (Fibonacci) team: m3 Issues for m3 type: bug 🐛 labels Jan 19, 2022
@tmcconechy tmcconechy added this to Triage in Enterprise (Next) Sprint Grooming via automation Jan 19, 2022
@whernebrink
Copy link
Collaborator Author

Some additional details to this.

This works (first opening the modal, then apply the cssClass do the dialogRef), which is kinda weird and differs from how we usually use the soho modal one:
image

Seems to be because of the following code in soho-contextual-action-panel.ref.ts wich checks to see that the dialog is open:
image

@jbrcna
Copy link

jbrcna commented Mar 2, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment