Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IdsTimePicker - Separate Popup into its own component #1063

Closed
4 tasks done
EdwardCoyle opened this issue Dec 23, 2022 · 0 comments · Fixed by #1104
Closed
4 tasks done

IdsTimePicker - Separate Popup into its own component #1063

EdwardCoyle opened this issue Dec 23, 2022 · 0 comments · Fixed by #1104
Assignees
Labels
type: enhancement ✨ New feature or request [5] Velocity rating (Fibonacci)

Comments

@EdwardCoyle
Copy link
Contributor

EdwardCoyle commented Dec 23, 2022

Is your feature request related to a problem or use case? Please describe.
This is a followup issue to #958 specifically for moving the IdsTimePicker's popup content into its own component.

Describe the solution you'd like

  • Separate IdsTimePicker's "Popup" content into its own component, extending IdsPickerPopup (see the design of IdsDatePickerPopup and follow the same pattern)
  • Re-integrate this new component in place of the existing popup element inside IdsTimePicker
  • Review integration of IdsTimePicker into IdsDatePickerPopup/other existing components to make sure everything still works
  • Update docs/tests to reflect new design

Additional context
Follows up #958

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement ✨ New feature or request [5] Velocity rating (Fibonacci)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

1 participant