Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IdsDatagrid: Tree not selecting or collapsing all children #1284

Closed
scott-campbell-infor opened this issue May 17, 2023 · 5 comments · Fixed by #1350
Closed

IdsDatagrid: Tree not selecting or collapsing all children #1284

scott-campbell-infor opened this issue May 17, 2023 · 5 comments · Fixed by #1350
Assignees
Labels
type: bug 🐛 Something isn't working [3] Velocity rating (Fibonacci)

Comments

@scott-campbell-infor
Copy link

Describe the bug
When using the IDS Datagrid with the tree-grid set to true there are a couple of issues

  1. collapsing expanded rows will only collapse the first child record, not all
  2. selecting a parent record will only select the parent row and the first child
  3. clicking the parent selection box to remove the tick, only deselects the parent

To Reproduce
Using the Enterprise-WC-Examples-Main as at 2023-05-17

Add the attached component to the ids-data-grid/demos for Angular
tree.zip

Initial state:
image

Steps to reproduce the behavior:

Collapsing children

  1. click on the minus of the first record to collapse the children, only the first child is collapsed

image

Selecting parent records

  1. click on checkbox for the the parent record, only the parent and the first child are selected

image

Deselecting the parent record

  1. click on the checked checkbox for the parent record, only the parent record is deselected

image

Expected behavior
Collapsing children - all the children should be collapsed
Selecting parent checkbox - all the children should have the checkbox ticked
Deselecting parent checkbox - all children should have the checkbox tick removed

Version

  • ids-enterprise-wc: 1.0.0-beta.8
  • Example testing using the enterprise-wc-examples as at 2023-05-17

Platform

  • Infor Application/Team Name: Infor Solutions and Innovations
  • OS Version: Windows 11
  • Browser Name: Chrome
  • Browser Version: 113.0.5672.93
@tmcconechy tmcconechy added type: bug 🐛 Something isn't working [3] Velocity rating (Fibonacci) labels May 17, 2023
@hey-yall
Copy link
Collaborator

Design work racked under https://jira.infor.com/browse/IDS-1202

@tmcconechy
Copy link
Member

hey @scott-campbell-infor i noticed we had a setting for this groupSelectsChildren or `group-selects-children="true" in the UI.

If you add that does it behave the way you expect? Example has it here https://main.wc.design.infor.com/ids-data-grid/tree-grid.html

@clayinfor
Copy link
Collaborator

clayinfor commented Jun 5, 2023

Hey @tmcconechy, I checked groupSelectsChildren and it appears that the attached zip-file does have that option enabled in the angular example, so that's not a problem...

@clayinfor
Copy link
Collaborator

Here's a working example of multiselect tree-grid in Enterprise 4x version:
https://main-enterprise.demo.design.infor.com/components/datagrid/test-tree-multiselect.html

@tmcconechy
Copy link
Member

ok i wasnt sure. But if you can reproduce it now. Please look for a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Something isn't working [3] Velocity rating (Fibonacci)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

5 participants