-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1284 - Datagrid tree not selecting or collapsing all children #1350
1284 - Datagrid tree not selecting or collapsing all children #1350
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@clayinfor everything looks good regarding expanding and collapsing but i see a related issue
- on http://localhost:4300/ids-data-grid/tree-grid.html
- collapse all parents (Building 4 and Building 5) so they are all collapsed
- sort on the name column
- notice after rerender/sort the children are reopened. (should be a rowExpanded) on the data it reads in the formatter. So should respect sorting.
…t-selecting-collapsing-all-children
…t-selecting-collapsing-all-children
…llapse/expand state while sorting)
hey @tmcconechy , the sort issue you mentioned here is now fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks @clayinfor just tried to update the PR to retrigger percy. Lets see if that helps
Explain the details for making this change. What existing problem does the pull request solve?
Collapsing children on datagrid tree-view - all the children should be collapsed
Selecting parent checkbox - all the children should have the checkbox ticked
Deselecting parent checkbox - all children should have the checkbox tick removed
Related github/jira issue (required):
Closes #1284
Steps necessary to review your pull request (required):
nvm use && npm run start
npx jest -- data-grid-func-test
npm run publish:link
enterprise-wc-examples/angular-ids-wc
src/app/components/ids-data-grid/demos/
/tree
route forTreeComponent
here:src/app/components/ids-data-grid/ids-data-grid-routing.module.ts
TreeComponent
here:src/app/components/ids-data-grid/ids-data-grid.module.ts
rm -fr ./.angular/cache
npm run build
npm run start
Included in this Pull Request: