Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1284 - Datagrid tree not selecting or collapsing all children #1350

Merged

Conversation

clayinfor
Copy link
Collaborator

@clayinfor clayinfor commented Jun 26, 2023

Explain the details for making this change. What existing problem does the pull request solve?

Collapsing children on datagrid tree-view - all the children should be collapsed
Selecting parent checkbox - all the children should have the checkbox ticked
Deselecting parent checkbox - all children should have the checkbox tick removed

Related github/jira issue (required):

Closes #1284

Steps necessary to review your pull request (required):

  1. Check out branch and run: nvm use && npm run start
  2. Open http://localhost:4300/ids-data-grid/tree-grid.html
  3. Verify you're able to collapse all parents and children on tree grid using plus/minus sign
  4. Verify you're able to select all parents and children on tree grid using checkboxes
  5. Run tests to ensure they all pass: npx jest -- data-grid-func-test
  6. Run npm run publish:link
  7. Switch to enterprise-wc-examples/angular-ids-wc
  8. Copy zip file from IdsDatagrid: Tree not selecting or collapsing all children #1284 to src/app/components/ids-data-grid/demos/
  9. Add /tree route for TreeComponent here: src/app/components/ids-data-grid/ids-data-grid-routing.module.ts
  10. Add TreeComponent here: src/app/components/ids-data-grid/ids-data-grid.module.ts
  11. Run rm -fr ./.angular/cache
  12. Run npm run build
  13. Run npm run start
  14. Open http://localhost:4200/ids-data-grid/tree
  15. Verify you're able to collapse all parents and children on tree grid using plus/minus sign
  16. Verify you're able to select all parents and children on tree grid using checkboxes

Included in this Pull Request:

  • An e2e or functional test for the bug or feature.
  • A note to the change log.

@clayinfor clayinfor requested a review from a team as a code owner June 26, 2023 15:36
@clayinfor clayinfor linked an issue Jun 26, 2023 that may be closed by this pull request
Copy link
Member

@tmcconechy tmcconechy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clayinfor everything looks good regarding expanding and collapsing but i see a related issue

  1. on http://localhost:4300/ids-data-grid/tree-grid.html
  2. collapse all parents (Building 4 and Building 5) so they are all collapsed
  3. sort on the name column
  4. notice after rerender/sort the children are reopened. (should be a rowExpanded) on the data it reads in the formatter. So should respect sorting.

@tmcconechy tmcconechy added the status: wip 🚧 Work in Progress (Ignore for now) label Jun 28, 2023
@clayinfor clayinfor removed the status: wip 🚧 Work in Progress (Ignore for now) label Jun 29, 2023
@clayinfor
Copy link
Collaborator Author

@clayinfor everything looks good regarding expanding and collapsing but i see a related issue

  1. on http://localhost:4300/ids-data-grid/tree-grid.html
  2. collapse all parents (Building 4 and Building 5) so they are all collapsed
  3. sort on the name column
  4. notice after rerender/sort the children are reopened. (should be a rowExpanded) on the data it reads in the formatter. So should respect sorting.

hey @tmcconechy , the sort issue you mentioned here is now fixed

tmcconechy
tmcconechy previously approved these changes Jun 30, 2023
Copy link
Member

@tmcconechy tmcconechy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @clayinfor just tried to update the PR to retrigger percy. Lets see if that helps

EdwardCoyle
EdwardCoyle previously approved these changes Jul 6, 2023
@tmcconechy tmcconechy dismissed stale reviews from EdwardCoyle and themself via 06a48d5 July 7, 2023 14:29
@tmcconechy tmcconechy merged commit 2852535 into main Jul 7, 2023
1 check passed
@tmcconechy tmcconechy deleted the 1284-datagrid-tree-not-selecting-collapsing-all-children branch July 7, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IdsDatagrid: Tree not selecting or collapsing all children
3 participants