Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IdsDataGrid: When pressing Shift+(ArrowUp/ArrowDown) on the row instead of row being selected nothing happens. #1330

Closed
jjorge1999 opened this issue Jun 13, 2023 · 2 comments · Fixed by #1370
Assignees
Labels
team: m3 type: bug 🐛 Something isn't working [2] Velocity rating (Fibonacci)

Comments

@jjorge1999
Copy link

jjorge1999 commented Jun 13, 2023

Describe the bug
When pressing Shift+(ArrowUp/ArrowDown) instead of row being selected nothing happens.

To Reproduce

Steps to reproduce the behavior:

  1. Go to 'http://localhost:4300/ids-data-grid/multiple-selection.html'
  2. Select atleast 1 row.
  3. Press Shift+(ArrowUp/ArrowDown)

Expected behavior
Multi-select the rows with cell navigation when Shift is pressed.

Version

  • ids-enterprise-wc: 1.0.0-beta.11

Screenshots
image

Untitled.mp4

Platform
-Infor Application/Team Name: M3 UX
-OS Version: Windows 11
-Browser Name: chrome
-Browser Version: 113.0.5672.127 (Official Build) (64-bit)

Additional context
Add any other context about the problem here.

@jjorge1999 jjorge1999 changed the title When pressing Shift+(ArrowUp/ArrowDown) on the instead of being selected nothing happens. When pressing Shift+(ArrowUp/ArrowDown) instead of being selected nothing happens. Jun 13, 2023
@jjorge1999 jjorge1999 changed the title When pressing Shift+(ArrowUp/ArrowDown) instead of being selected nothing happens. When pressing Shift+(ArrowUp/ArrowDown) on the row instead of row being selected nothing happens. Jun 13, 2023
@tmcconechy tmcconechy changed the title When pressing Shift+(ArrowUp/ArrowDown) on the row instead of row being selected nothing happens. IdsDataGrid: When pressing Shift+(ArrowUp/ArrowDown) on the row instead of row being selected nothing happens. Jun 13, 2023
@tmcconechy tmcconechy added type: bug 🐛 Something isn't working [2] Velocity rating (Fibonacci) team: m3 labels Jun 13, 2023
@tmcconechy
Copy link
Member

tmcconechy commented Jul 7, 2023

@jjorge1999 Im not sure that shift and arrow key is correct behavior can you try #1370

Since space or enter selects that should be involved somehow.

  • shift + enter should select row ranged between the two clicks
  • but shift + arrow should only check if space or enter is used -> do you agree. I.E space then arrow down then shift space or shift click should select the range

@glenlieorillo
Copy link
Contributor

Working as expected using the shift key+arrow up/down to select row/s.

Screen.Recording.2023-07-13.at.7.11.43.PM.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team: m3 type: bug 🐛 Something isn't working [2] Velocity rating (Fibonacci)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants