Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IdsTextarea: Two issues related to characterCounter #1598

Closed
volante007 opened this issue Nov 2, 2023 · 5 comments · Fixed by #1605
Closed

IdsTextarea: Two issues related to characterCounter #1598

volante007 opened this issue Nov 2, 2023 · 5 comments · Fixed by #1605
Assignees
Labels
type: bug 🐛 Something isn't working [2] Velocity rating (Fibonacci)

Comments

@volante007
Copy link

volante007 commented Nov 2, 2023

Describe the bug

  1. It doesn't seem like it's possible to hide the character counter below the textarea. There is a setting in the documentation, characterCounter (I assume it's corresponding attribute would be character-counter?), but it doesn't work.
  2. The "characters left" text isn't translated

To Reproduce #1

  1. Edit one of the textarea demos to use the character-counter attribute, like
<ids-textarea maxlength="500" character-counter="false"><ids-textarea>

Result: Character counter isn't hidden

To Reproduce #2

  1. Go to https://main.wc.design.infor.com/ids-textarea/example.html
  2. Change locale to something else than English
  3. See example that uses the standard characters left text for the counter (max length example left column)
    Result: Text shown in English

Version

  • ids-enterprise-wc: v1.0.0-beta.16

Screenshots
MicrosoftTeams-image (6)

Platform

  • Infor Application/Team Name: OS Portal
@tmcconechy tmcconechy added type: bug 🐛 Something isn't working [2] Velocity rating (Fibonacci) labels Nov 2, 2023
@tmcconechy
Copy link
Member

  1. You mean you cant turn it off once its first turned on correct? I can see why its just removing the attribute here https://github.com/infor-design/enterprise-wc/blob/main/src/components/ids-textarea/ids-textarea.ts#L690 needs to remove the label.

  2. The string should be added to the translations. Seems hard coded https://github.com/infor-design/enterprise-wc/blob/main/src/components/ids-textarea/ids-textarea.ts#L59

@volante007
Copy link
Author

volante007 commented Nov 2, 2023

  1. I want it off completely, so it's not turned on explicitly by me before that. Just setting character-counter="false". It seems from that code that it can only be used as a setter on the component, not set through the attribute?

  2. Oh, right. Yes that was a clear one :)

@tmcconechy
Copy link
Member

  1. if you want it off completely seems like most of them on this page do not have it https://main.wc.design.infor.com/ids-textarea/example.html ? or i guess you want maxlength but no character count and that doesnt work?

@volante007
Copy link
Author

Yes that's right, maxlength without character counter

@jbrcna
Copy link
Contributor

jbrcna commented Nov 15, 2023

QA PAssed.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Something isn't working [2] Velocity rating (Fibonacci)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants