Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IdsLayoutGrid: Include CSS class names for ids-layout-flex, and ids-layout-grid #1763

Closed
guoliang opened this issue Jan 16, 2024 · 3 comments · Fixed by #2144
Closed

IdsLayoutGrid: Include CSS class names for ids-layout-flex, and ids-layout-grid #1763

guoliang opened this issue Jan 16, 2024 · 3 comments · Fixed by #2144
Assignees
Labels
type: bug 🐛 Something isn't working [2] Velocity rating (Fibonacci)

Comments

@guoliang
Copy link

Is your feature request related to a problem or use case? Please describe.
We have a case where we cannot use the corresponding web component for flex, or grid layout directly. So we need to use the class names for it instead.

Describe the solution you'd like
In the current beta version, Flex and Grid have stylesheets generated called ids-layout-grid.css and ids-layout-flex.css, which contain some class names. I believe they are mainly used for the CSS standalone examples given for each layout component. I would like it to be expanded to include class names for every style property currently used in the Flex and Grid web components.

@tmcconechy tmcconechy added type: bug 🐛 Something isn't working [2] Velocity rating (Fibonacci) labels Jan 16, 2024
@tmcconechy tmcconechy changed the title Include CSS class names for ids-layout-flex, and ids-layout-grid IdsLayoutGrid: Include CSS class names for ids-layout-flex, and ids-layout-grid Jan 16, 2024
@tmcconechy
Copy link
Member

The missing ones are:

.ids-layout-grid-align-items-start {
  align-items: start;
}
.ids-layout-grid-align-items-center {
  align-items: center;
}
.ids-layout-grid-align-items-end {
  align-items: end;
}

@tmcconechy
Copy link
Member

cc @jmacaluso711 ?

@jbrcna
Copy link
Contributor

jbrcna commented Apr 15, 2024

QA Passed
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Something isn't working [2] Velocity rating (Fibonacci)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants