Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IdsColorPicker: Remaining Features/Issues #551

Closed
14 of 20 tasks
tmcconechy opened this issue Feb 16, 2022 · 1 comment · Fixed by #746
Closed
14 of 20 tasks

IdsColorPicker: Remaining Features/Issues #551

tmcconechy opened this issue Feb 16, 2022 · 1 comment · Fixed by #746

Comments

@tmcconechy
Copy link
Member

tmcconechy commented Feb 16, 2022

Description
Lists the Remaining Bugs/Features for a 100% Component

Major

  • https://main-enterprise.demo.design.infor.com/components/editor/example-index.html - editor version
  • Fix the keyboard (arrow down , enter, keys around the colors ect), and fix focus state around swatches
  • Tooltip on the colors
  • Fix all the states See example and also see
  • Check Styles match with 4.x on the popup container - swatch/hover/spacing/selected state on swatches
  • Default color list should load from our theme palette node_modules/ids-identity/dist/theme-new/tokens/web/ui.config.color-palette.js
  • Check mark color should change based on swatch background (check mark color can get from colorlist -arrowClass)
  • Standardize/Abstract out Popup/Picker/"return value" interface (to be used in this and other pickers)
  • Check JSDoc comments for everything that's missing
  • Add test for change event firing
  • Add test for setting color / clearing color
  • Change hide/show to open/close for consistency and make sure it fires events that are documented
  • Ability to set custom labels for selections. Should be able to show color-name azure06 or color-hex #ffffff inside the input. See example
  • Show label instead of hex. See example
  • Add sizes widths and field heights. See Ids Input
  • Add dirty tracker example to the example page

Minor

  • Some text hard coded in component, should give setting/slots to user change those text strings ids-text audible="true"
  • Enable/Disable standard HTML colorpicker independently of other colorpicker parts using a boolean attribute
  • Click the swatch to select / option for the "advanced" picker
  • Add side by side example
@tmcconechy tmcconechy added [5] Velocity rating (Fibonacci) type: enhancement ✨ New feature or request labels Feb 16, 2022
@tmcconechy tmcconechy added this to To do in Mar 1 -15 Web Components 2022 Sprint via automation Feb 24, 2022
@EdwardCoyle
Copy link
Contributor

@clayinfor another Color Picker issue we discovered while testing #569 - the check marks on selected swatches need to be centered in the swatch. I left this alone in that PR since we need to revisit the style of all elements inside the Popup anyway:

Screen Shot 2022-03-07 at 12 17 02 PM

@tmcconechy tmcconechy added this to To do in Mar 15 -31 Web Components 2022 Sprint via automation Mar 18, 2022
@clayinfor clayinfor moved this from To do to In progress in Mar 1 -15 Web Components 2022 Sprint Mar 21, 2022
@clayinfor clayinfor moved this from To do to In progress in Mar 15 -31 Web Components 2022 Sprint Mar 21, 2022
@tmcconechy tmcconechy added this to To do in April 1 -30 Web Components 2022 Sprint via automation Mar 31, 2022
@tmcconechy tmcconechy moved this from To do to In progress in April 1 -30 Web Components 2022 Sprint Mar 31, 2022
@tmcconechy tmcconechy added this to To do in May 1 -15 Web Components 2022 Sprint via automation Apr 28, 2022
@tmcconechy tmcconechy moved this from To do to In progress in May 1 -15 Web Components 2022 Sprint Apr 28, 2022
@tmcconechy tmcconechy added the Epic ⚡ A large body of work, broken down in smaller issues label May 17, 2022
@tmcconechy tmcconechy added this to To do in May 15 - 31 Web Components 2022 Sprint via automation May 26, 2022
@tmcconechy tmcconechy moved this from To do to In progress in May 15 - 31 Web Components 2022 Sprint May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic ⚡ A large body of work, broken down in smaller issues type: enhancement ✨ New feature or request [5] Velocity rating (Fibonacci)
Development

Successfully merging a pull request may close this issue.

3 participants