551: Fix IdsColorPicker and IdsColor remaining features #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clayinfor
force-pushed
the
551-ids-color-picker-remaining-features
branch
from
aaf7203
to
cb834da
Compare
clayinfor
force-pushed
the
551-ids-color-picker-remaining-features
branch
from
cb834da
to
4093b0d
Compare
EdwardCoyle
reviewed
May 31, 2022
tmcconechy
requested changes
Jun 1, 2022
There was a problem hiding this comment.
Some smaller issues (mostly minor but worth a quick look if possible)
- on http://localhost:4300/ids-color/example.html if you tab through, some have a nice focus state and some are missing. Also can the focus ring have a border radius?
- similar on the popup i see a double focus state (outline showing)
Not show here i couldnt screen shot it:
- can make the width bigger on the tooltip
… color-picker alignment)
…-color-picker/demos/example.html)
tmcconechy
approved these changes
Jun 8, 2022
andriivarhanov
approved these changes
Jun 8, 2022
|
@clayinfor the only thing im wondering is whats up with this page https://percy.io/00aaa841/enterprise-wc/builds/18745859/changed/1051830286?browser=chrome&browser_ids=23&subcategories=unreviewed%2Cchanges_requested&viewLayout=side-by-side&viewMode=new&width=1280&widths=375%2C1280 ? Do we need a quick adjustment to the responsive grid? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the details for making this change. What existing problem does the pull request solve?
Fixes remaining Bugs/Features for a 100% IdsColorPicker Component
Related github/jira issue (required):
Closes #551
Steps necessary to review your pull request (required):
See examples components below:
Included in this Pull Request: