Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IdsInput: Bug with time validation #805

Closed
tmcconechy opened this issue Jul 13, 2022 · 0 comments · Fixed by #960
Closed

IdsInput: Bug with time validation #805

tmcconechy opened this issue Jul 13, 2022 · 0 comments · Fixed by #960
Assignees
@andriivarhanov
Labels
type: bug 🐛 Something isn't working [3] Velocity rating (Fibonacci)

Comments

@tmcconechy
Copy link
Member

tmcconechy commented Jul 13, 2022 •
edited

Describe the bug
The validation doesnt work right for time.

To Reproduce

Steps to reproduce the behavior:

  1. Go to http://localhost:4300/ids-input/example.html
  2. Try to type a time like 10:12 AM
  3. Tab out

Expected behavior
a. should only validate when leaving the field (this is a validation setting)
b. should be valid
c. also test with 24 time like: 'HH:mm' and make sure all works
d. ensure the mask works with each case too

Additional context
Cases:

HH.mm (24 hr) -> 22:00
hh:mm a(12 hr) -> 08:01 AM

H:mm (24 hr no padded zero) -> 8:00 or 21:00
h:mm a (12 hr no padded zero) -> 8:00 AM
@tmcconechy tmcconechy added type: bug 🐛 Something isn't working [3] Velocity rating (Fibonacci) labels Jul 13, 2022
andriivarhanov added a commit that referenced this issue Oct 12, 2022
@andriivarhanov
Adjust time validation for ids-input #805
d09785d
andriivarhanov added a commit that referenced this issue Oct 12, 2022
@andriivarhanov
Add date validation examples #805
3aea70e
@andriivarhanov andriivarhanov mentioned this issue Oct 12, 2022
Merged
2 tasks
andriivarhanov added a commit that referenced this issue Oct 17, 2022
@andriivarhanov
Add strict check for minutes and day periods with strictTime option #805
c14ee4e
andriivarhanov added a commit that referenced this issue Oct 17, 2022
@andriivarhanov
Add func test for strictTime no day period time #805
f049a7a
andriivarhanov added a commit that referenced this issue Oct 18, 2022
@andriivarhanov
Merge branch 'main' into 947-ids-time-picker-memory-leak
96d1e6e 
* main: (30 commits)
  Add func test for strictTime no day period time #805
  Add strict check for minutes and day periods with strictTime option #805
  Add date validation examples #805
  Adjust time validation for ids-input #805
  fix types for error TS2611
  update changelog
  Fix build copy command
  chart types
  test cleanup, fix lint
  more component type fixes
  more component type fixes
  tabs, month/week view, date/time picker types
  merge main type fix
  checkbox, editor, form types
  dropdown, pager, progress, upload, lookup types
  block-grid-item type
  about, accordion, actionpanel, tree, ratings types
  menu, popupmenu, trigger field, toolbar types
  ids input, toast, trigger button
  button, toast, treemap, upload types
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andriivarhanov andriivarhanov

Labels
type: bug 🐛 Something isn't working [3] Velocity rating (Fibonacci)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

805 - IdsInput fix time validation infor-design/enterprise-wc
2 participants
@tmcconechy @andriivarhanov