Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IdsScrollView: Remove hash links for navigation #904

Closed
jmacaluso711 opened this issue Aug 31, 2022 · 1 comment · Fixed by #1264
Closed

IdsScrollView: Remove hash links for navigation #904

jmacaluso711 opened this issue Aug 31, 2022 · 1 comment · Fixed by #1264
Assignees
@deep7102
Labels
type: enhancement ✨ New feature or request [2] Velocity rating (Fibonacci)

Comments

@jmacaluso711
Copy link
Contributor

Describe the bug
Find an alternate solution to using hash links in the ids-scroll-view component to avoid issues within SPA frameworks routing systems

To Reproduce

Steps to reproduce the behavior:

  1. Pull angular-ids-wc example branch https://github.com/infor-design/enterprise-wc-examples/tree/316-angular-examples
  2. npm i && start
  3. go to http://localhost:4200/ids-scroll-view/example
  4. See error

Version

  • ids-enterprise: [e.g. v4.9.0 or v4.10.0]

Screenshots
n/a

Platform

  • Infor Application/Team Name: [e.g. Infor XYZ, Infor ABC]
  • Device: (if applicable) [e.g. iPhone 6 or Samsung Galaxy S6]
  • OS Version: [e.g. Windows 10 or iOS 8]
  • Browser Name: [e.g. chrome, safari, stock browser]
  • Browser Version: [e.g. 22, 66.0.3359.181 (Official Build) (64-bit)]

Additional context
n/a
@jmacaluso711 jmacaluso711 added the type: enhancement ✨ New feature or request label Aug 31, 2022
@jmacaluso711 jmacaluso711 mentioned this issue Sep 14, 2022
Closed
@tmcconechy tmcconechy added the [2] Velocity rating (Fibonacci) label Mar 28, 2023
@tmcconechy
Copy link
Member

  • dont use href / effect the URL
  • make sure there is an api to focus a image

This was referenced May 1, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deep7102 deep7102

Labels
type: enhancement ✨ New feature or request [2] Velocity rating (Fibonacci)
Projects
No open projects
Web Components (Apr 1 - 15) Sprint
Status: In Progress
Web Components (Apr 15 - 30) Sprint
Status: PR Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

904, 1230 - Fix to remove hash links for navigation with scroll view infor-design/enterprise-wc
3 participants
@tmcconechy @jmacaluso711 @deep7102