Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc: Quick Change to Hyperlink focus #110

Merged
merged 17 commits into from
May 7, 2021
Merged

Misc: Quick Change to Hyperlink focus #110

merged 17 commits into from
May 7, 2021

Conversation

tmcconechy
Copy link
Member

Explain the details for making this change. What existing problem does the pull request solve?

The way i did focus state was not right and didn't work when multiline elements so changed it to a border.
Also added the ability to take off the underline.

Related github/jira issue (required):
https://github.com/infor-design/enterprise/issues/4973

Steps necessary to review your pull request (required):

Included in this Pull Request:

  • An e2e or functional test for the bug or feature.

@tmcconechy tmcconechy requested a review from a team as a code owner May 6, 2021 17:27
@tmcconechy tmcconechy closed this May 6, 2021
@tmcconechy tmcconechy reopened this May 6, 2021
Copy link
Contributor

@rob2d rob2d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good straightforward fix. Only had some small comment on the new textUnderline prop.

src/ids-hyperlink/ids-hyperlink.js Outdated Show resolved Hide resolved
src/ids-hyperlink/ids-hyperlink.js Outdated Show resolved Hide resolved
test/ids-hyperlink/ids-hyperlink-func-test.js Show resolved Hide resolved
@tmcconechy
Copy link
Member Author

@rob2d I fixed one comment - good call on that. But not sure what you mean about the other stuff 100%. But it seems ok to me from my thinking

@tmcconechy
Copy link
Member Author

@rob2d after explaining that makes sense pushed a fix

Copy link
Contributor

@rob2d rob2d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes Tim. Looks good 🍌

@tmcconechy tmcconechy merged commit 6121065 into main May 7, 2021
@tmcconechy tmcconechy deleted the hyperlink-focus branch May 7, 2021 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants