-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc: Quick Change to Hyperlink focus #110
Conversation
…wc into hyperlink-focus
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a good straightforward fix. Only had some small comment on the new textUnderline
prop.
@rob2d I fixed one comment - good call on that. But not sure what you mean about the other stuff 100%. But it seems ok to me from my thinking |
@rob2d after explaining that makes sense pushed a fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes Tim. Looks good 🍌
Explain the details for making this change. What existing problem does the pull request solve?
The way i did focus state was not right and didn't work when multiline elements so changed it to a border.
Also added the ability to take off the underline.
Related github/jira issue (required):
https://github.com/infor-design/enterprise/issues/4973
Steps necessary to review your pull request (required):
Included in this Pull Request: