Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Add new deps #1165

Closed
wants to merge 11 commits into from
Closed

Chore: Add new deps #1165

wants to merge 11 commits into from

Conversation

tmcconechy
Copy link
Member

@tmcconechy tmcconechy commented Mar 8, 2023

Explain the details for making this change. What existing problem does the pull request solve?
Updates a few deps. Mainly a test to confirm percy/cli#1194 (comment) by running a build.

NOTE: Percy Support might be looking at this. Hold until WIP is removed.

Related github/jira issue (required):
percy/cli#1194

Steps necessary to review your pull request (required):

  • checks pass
  • npm i is clean of errors

@tmcconechy tmcconechy requested a review from a team as a code owner March 8, 2023 15:01
EdwardCoyle
EdwardCoyle previously approved these changes Mar 8, 2023
Copy link
Contributor

@EdwardCoyle EdwardCoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems fine, but a question below about one item:

package.json Outdated Show resolved Hide resolved
@tmcconechy tmcconechy added the status: wip 🚧 Work in Progress (Ignore for now) label Mar 8, 2023
@tmcconechy tmcconechy removed the status: wip 🚧 Work in Progress (Ignore for now) label Mar 10, 2023
@tmcconechy tmcconechy added the status: wip 🚧 Work in Progress (Ignore for now) label Mar 13, 2023
@tmcconechy tmcconechy closed this Mar 15, 2023
@tmcconechy tmcconechy deleted the new-deps branch March 15, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: wip 🚧 Work in Progress (Ignore for now)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants