-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1050 - Sync IdsTabs and related components with 4.x Alabaster theme changes #1593
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but a few things on review:
- the disabled color on http://localhost:4300/ids-tabs/vertical.html in dark mode seems hard to see maybe up it one
- on http://localhost:4300/ids-tabs/module.html the icons look abit out of alignment
3) on http://localhost:4300/ids-header/example.html in darkmode the placeholder text is hard to see
-
on http://localhost:4300/ids-header/example.html in darkmode if you hover the buttons the hover state is missing
-
http://localhost:4300/ids-tabs/header-tabs.html in dark mode the disabled is hard to see (maybe move it up 1)
-
on http://localhost:4300/ids-tabs/example.html the underline on the selected state is a lot slimmer than on https://main-enterprise.demo.design.infor.com/components/tabs/example-index.html
I have some outstanding questions on what's actually approved on the tab designs after discussing, so placing on hold for now: https://www.figma.com/file/gRpli2TgQ3scLE6GF4e2Hz?node-id=199:36686&mode=design#602711280 |
@tmcconechy I think all the points above have been addressed now |
Explain the details for making this change. What existing problem does the pull request solve?
This PR syncs Header/Vertical/Module tabs styles with changes that were made to accommodate the Alabaster color scheme in the Enterprise components, making them the default in the Web Components.
In addition, some features were added and some bugs fixed in related components:
IdsTabsContext
in order to allow Vertical Tabs components to stretch the full height of their parent containers.IdsTabsContext
component for easier configuration of Vertical Tabs.Related github/jira issue (required):
Closes #1050
Steps necessary to review your pull request (required):
Pull/build/run, then test the following using the latest Figma design changes as a reference:
Alabaster Design Sync:
Make sure the following sample pages match the provided designs. Test all theme modes (light/dark/contrast):
Dismissible Tabs bug:
Auto fit/Orientation:
Included in this Pull Request: