Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1050 - Sync IdsTabs and related components with 4.x Alabaster theme changes #1593

Merged
merged 16 commits into from
Nov 15, 2023

Conversation

EdwardCoyle
Copy link
Contributor

Explain the details for making this change. What existing problem does the pull request solve?
This PR syncs Header/Vertical/Module tabs styles with changes that were made to accommodate the Alabaster color scheme in the Enterprise components, making them the default in the Web Components.

In addition, some features were added and some bugs fixed in related components:

  • Fixed a bug where it was no longer possible to dismiss tabs (specifically in Module Tabs).
  • Added an "Add Tab" and "Reset" button to the header tabs example.
  • Added "auto-fit" setting to IdsTabsContext in order to allow Vertical Tabs components to stretch the full height of their parent containers.
  • Added "orientation" setting to IdsTabsContext component for easier configuration of Vertical Tabs.

Related github/jira issue (required):
Closes #1050

Steps necessary to review your pull request (required):
Pull/build/run, then test the following using the latest Figma design changes as a reference:

Alabaster Design Sync:
Make sure the following sample pages match the provided designs. Test all theme modes (light/dark/contrast):

Dismissible Tabs bug:

  • Open http://localhost:4300/ids-tabs/module.html
  • Use the Add Tab "+" button to add enough tabs that the "More Tabs" menu appears
  • Try dismissing tabs from both the tabs themselves, and the popup menu, using the "x" button. Both should cause their tabs and panels to be dismissed.

Auto fit/Orientation:

  • Open http://localhost:4300/ids-tabs/vertical.html
  • See that the Vertical Tabs and the content panels should stretch their entire page height.
  • Additionally the whole thing should be "vertical" (the setting is now being passed down from IdsTabsContext)

Included in this Pull Request:

  • A note to the change log.

Copy link
Member

@tmcconechy tmcconechy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but a few things on review:

  1. the disabled color on http://localhost:4300/ids-tabs/vertical.html in dark mode seems hard to see maybe up it one
  2. on http://localhost:4300/ids-tabs/module.html the icons look abit out of alignment

Screenshot 2023-11-01 at 10 16 18 AM
3) on http://localhost:4300/ids-header/example.html in darkmode the placeholder text is hard to see

Screenshot 2023-11-01 at 10 18 37 AM

  1. on http://localhost:4300/ids-header/example.html in darkmode if you hover the buttons the hover state is missing

  2. http://localhost:4300/ids-tabs/header-tabs.html in dark mode the disabled is hard to see (maybe move it up 1)

  3. on http://localhost:4300/ids-tabs/example.html the underline on the selected state is a lot slimmer than on https://main-enterprise.demo.design.infor.com/components/tabs/example-index.html

src/components/ids-menu/ids-menu-item.scss Outdated Show resolved Hide resolved
@EdwardCoyle EdwardCoyle added status: wip 🚧 Work in Progress (Ignore for now) design Needs input from IDS Design Team labels Nov 1, 2023
@EdwardCoyle
Copy link
Contributor Author

I have some outstanding questions on what's actually approved on the tab designs after discussing, so placing on hold for now: https://www.figma.com/file/gRpli2TgQ3scLE6GF4e2Hz?node-id=199:36686&mode=design#602711280

@EdwardCoyle EdwardCoyle removed status: wip 🚧 Work in Progress (Ignore for now) design Needs input from IDS Design Team labels Nov 8, 2023
@EdwardCoyle
Copy link
Contributor Author

@tmcconechy I think all the points above have been addressed now

tmcconechy
tmcconechy previously approved these changes Nov 9, 2023
tmcconechy
tmcconechy previously approved these changes Nov 10, 2023
tmcconechy
tmcconechy previously approved these changes Nov 13, 2023
clayinfor
clayinfor previously approved these changes Nov 13, 2023
src/components/ids-popup-menu/ids-popup-menu.ts Outdated Show resolved Hide resolved
tmcconechy
tmcconechy previously approved these changes Nov 14, 2023
@tmcconechy tmcconechy merged commit 67db39a into main Nov 15, 2023
4 checks passed
@tmcconechy tmcconechy deleted the 1050-tabs-header-alabaster branch November 15, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IdsHeader/IdsTabs: Add new design changes
3 participants