Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1770 - Fix dropdown positon in data grid #1839

Merged
merged 3 commits into from
Feb 13, 2024
Merged

1770 - Fix dropdown positon in data grid #1839

merged 3 commits into from
Feb 13, 2024

Conversation

tmcconechy
Copy link
Member

Explain the details for making this change. What existing problem does the pull request solve?

Adds fixes to the dropdown position in data grid

Related github/jira issue (required):
Fixes #1770

Steps necessary to review your pull request (required):

  • go to http://localhost:4300/ids-data-grid/editable-lookup.html
  • in the last column open the dropdown and it should be positioned correctly
  • try this in each row height
  • try zooming
  • also try dragging columns and make sure they line up in each row height
  • try sorting in each row height and make sure the icons look ok

Included in this Pull Request:

  • A test for the bug or feature.
  • A note to the change log.

@tmcconechy tmcconechy requested a review from a team as a code owner February 12, 2024 17:58
@tmcconechy tmcconechy merged commit 43bef0a into main Feb 13, 2024
4 checks passed
@tmcconechy tmcconechy deleted the 1770-dropdown-pos branch February 13, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropdowns: On a cell of a datagrid appear far from the original cell
3 participants