Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

191 - Convert to use index import pattern #193

Merged
merged 8 commits into from
May 24, 2021
Merged

191 - Convert to use index import pattern #193

merged 8 commits into from
May 24, 2021

Conversation

tmcconechy
Copy link
Member

Explain the details for making this change. What existing problem does the pull request solve?

This PR:

  • moves all mixins to ids-mixins
  • sets up an index.js in ids-mixins and ids-base that can be imported
  • adjusts all imports
  • fixes a lint script bug
  • updates some minor deps

Related github/jira issue (required):
Closes #191

Steps necessary to review your pull request (required):

  • npm prune && npm i
  • Pull, Build, Run!
  • try the commands like npm run build and npm run start
  • do quick smoke test of what you know in the demo app

Included in this Pull Request:

  • An e2e or functional test for the bug or feature.

@tmcconechy tmcconechy requested a review from a team as a code owner May 19, 2021 17:52
deep7102
deep7102 previously approved these changes May 20, 2021
Copy link
Contributor

@deep7102 deep7102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems all fine

EdwardCoyle
EdwardCoyle previously approved these changes May 21, 2021
Copy link
Contributor

@EdwardCoyle EdwardCoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems well and working to me 👍

@tmcconechy tmcconechy added the status: wip 🚧 Work in Progress (Ignore for now) label May 21, 2021
@tmcconechy
Copy link
Member Author

Found a types issue will add that...

EdwardCoyle
EdwardCoyle previously approved these changes May 24, 2021
@tmcconechy tmcconechy removed the status: wip 🚧 Work in Progress (Ignore for now) label May 24, 2021
@tmcconechy tmcconechy merged commit 8e731ae into main May 24, 2021
@tmcconechy tmcconechy deleted the 191-mixin-move branch May 24, 2021 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

General: Move Mixins to a folder
3 participants