1806 - ids-toolbar misposition in header overflow menu #2276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmcconechy
reviewed
May 1, 2024
There was a problem hiding this comment.
@clayinfor the one issue i see is that its loosing the highlight.
The highlight used to stay on the both menu items similar to this:
jmacaluso711
reviewed
May 1, 2024
tmcconechy
requested changes
May 2, 2024
tmcconechy
reviewed
May 20, 2024
| if (this.containingElem?.classList?.contains('app-menu-is-open')) { | ||
| const appMenu = this.containingElem?.querySelector('.app-menu'); | ||
| const appMenuRect = appMenu?.getBoundingClientRect(); | ||
| if (navigator.userAgent.indexOf('Firefox') === -1) { |
There was a problem hiding this comment.
Does this cause a warning? May also want to sync main here as this PR is now pretty old
|
@clayinfor any updates on this one? Been sitting a long time |
|
@clayinfor any updates on this one? Been sitting a long time. Shouldnt need too much to finish it? |
…osition-in-header-overflow-menu Conflicts: doc/CHANGELOG.md src/components/ids-popup-menu/ids-popup-menu.ts
|
hey @tmcconechy, let's merge this, and create a new task to address the remaining issues. |
|
@clayinfor ok great. Can you make the issue as im not sure i know whats left? |
|
Ok @tmcconechy , I used John's comment to create an issue here. |
tmcconechy
deleted the
1806-ids-toolbar-misposition-in-header-overflow-menu
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the details for making this change. What existing problem does the pull request solve?
Fix so that menus and submenu popup positions are correct when using
IdsToolbarinsideIdsAppMenu(andIdsHeader)Related github/jira issue (required):
Closes #1806
Steps necessary to review your pull request (required):
nvm use && npm install && npm run startIncluded in this Pull Request: