Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2156 - ids-toolbar-more-actions can have disabled menu-items #2277

Merged
merged 23 commits into from
May 13, 2024

Conversation

clayinfor
Copy link
Collaborator

@clayinfor clayinfor commented May 1, 2024

Explain the details for making this change. What existing problem does the pull request solve?

Fix so that menu-items in IdsToolbarMoreActions can be disabled.

Related github/jira issue (required):

Closes #2156

Steps necessary to review your pull request (required):

  1. Check out this branch and run: nvm use && npm install && npm run start
  2. Go to: http://localhost:4300/ids-toolbar/example.html
  3. Click the "More" button (three-dots) on the right, and ensure the 1st menu-item is disabled.
  4. Click the "More Options" submenu item, and ensure the 2nd menu-item is disabled.
  5. Go to: http://localhost:4300/ids-toolbar/overflowed.html
  6. Click the "More" button (three-dots) on the right to open the popup.
  7. Resize the browser window to make smaller, and ensure that toolbar menu items move into popup.
  8. Go to: http://localhost:4300/ids-toolbar/disabled-partially.html
  9. Click the "More" button (three-dots) on the right to open the popup.
  10. Resize the browser window to make smaller, and ensure that toolbar menu items DO NOT move into popup.

Included in this Pull Request:

  • Some documentation for the feature.
  • A test for the bug or feature.
  • A note to the change log.

@clayinfor clayinfor requested a review from a team as a code owner May 1, 2024 11:25
@jmacaluso711 jmacaluso711 self-requested a review May 1, 2024 15:14
Copy link
Contributor

@jmacaluso711 jmacaluso711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the snapshot test is failing. Otherwise looks good

Copy link
Member

@tmcconechy tmcconechy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clayinfor marking as request changes to fix the tests

@clayinfor
Copy link
Collaborator Author

ok @tmcconechy , I'm currently fixing

@tmcconechy tmcconechy added the status: wip 🚧 Work in Progress (Ignore for now) label May 6, 2024
@clayinfor clayinfor removed the status: wip 🚧 Work in Progress (Ignore for now) label May 8, 2024
@tmcconechy
Copy link
Member

@clayinfor looks like you just need update those snapshots?

tmcconechy
tmcconechy previously approved these changes May 9, 2024
@tmcconechy tmcconechy merged commit ada7b11 into main May 13, 2024
1 of 2 checks passed
@tmcconechy tmcconechy deleted the 2156-ids-toolbar-more-actions-disbled branch May 13, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IdsToolbar: Menu items in IdsToolbarMoreActions can't be disabled
3 participants