-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2156 - ids-toolbar-more-actions can have disabled menu-items #2277
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the snapshot test is failing. Otherwise looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@clayinfor marking as request changes to fix the tests
ok @tmcconechy , I'm currently fixing |
…ed-partially.html)
…ed-partially.html)
@clayinfor looks like you just need update those snapshots? |
Explain the details for making this change. What existing problem does the pull request solve?
Fix so that menu-items in
IdsToolbarMoreActions
can be disabled.Related github/jira issue (required):
Closes #2156
Steps necessary to review your pull request (required):
nvm use && npm install && npm run start
Included in this Pull Request: