1179 - Datepicker: Ability to set first day of week #1326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericangeles
requested review from
davidcarlsonberg,
deep7102,
EdwardCoyle and
tmcconechy
as code owners
EdwardCoyle
suggested changes
Dec 3, 2018
|
|
||
| <script> | ||
| $('body').on('initialized', function () { | ||
| Locale.currentLocale.data.calendars[0].firstDayofWeek = 1; // starts on Monday |
There was a problem hiding this comment.
I think this type of fix is in "workaround" territory, only because it could potentially be unstable to the Locale system if it's using this property internally for other calendar functions. #1179 actually lists out that a Datepicker API setting for changing the first day of the week would be desirable. I'm thinking that would be a better fix.
tmcconechy
requested changes
Dec 3, 2018
There was a problem hiding this comment.
Sorry @ericangeles should have made this one more clear. To add some direction:
- add a setting firstDayOfWeek on the monthview component and datepicker component (datepicker one just sends it to month view)
- its initially null, if not set use Locale firstDayOfWeek but if it is set use the setting value instead of whats set in the locale (dont change the locale)
- add api tests ext.
- update the example to show the setting not the workaround
| <script> | ||
| $('body').on('initialized', function () { | ||
| Locale.currentLocale.data.calendars[0].firstDayofWeek = 1; // starts on Monday | ||
| $('my-datepicker').datepicker(); |
There was a problem hiding this comment.
Should prob be #date-field-normal
tmcconechy
requested changes
Dec 4, 2018
|
In addition to our comments will want to merge master to fix the tests |
tmcconechy
approved these changes
Dec 6, 2018
EdwardCoyle
approved these changes
Dec 10, 2018
This was referenced Dec 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the details for making this change. What existing problem does the pull request solve?
Adding a test template that will control the first day on the datepicker.
Adding a firstDayofWeek option to datepicker that overrides whats used in locale.
Related github/jira issue (required):
Closes #1179
Steps necessary to review your pull request (required):
firstDayofWeek