Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor: Bullet / numbered list item can't be turned into H3/H4 #2679

Closed
volante007 opened this issue Aug 22, 2019 · 4 comments · Fixed by #3619
Closed

Editor: Bullet / numbered list item can't be turned into H3/H4 #2679

volante007 opened this issue Aug 22, 2019 · 4 comments · Fixed by #3619
Assignees
@tmcconechy
Labels
focus: editor Main focus is Editor priority: trival Least important issues team: homepages Issues for the homepages team type: bug 🐛 [5] Velocity rating (Fibonacci)
Projects
Enterprise 4.27.x (March 2020) Sprint

Comments

@volante007
Copy link

Describe the bug
This is a minor issue. A bullet / numbered list item can't be turned into H3/H4. The style does look like it gets applied, since the buttons get active, but it remains a list item. Only seems to be an issue in Chrome & Safari.

To Reproduce

  1. Go to https://design.infor.com/code/ids-enterprise/latest/demo/components/editor/example-index
  2. Type something
  3. Turn text into bullet / number list
  4. Turn into H3/H4
    Result: Not turned into H3/H4

Expected behavior
Turned into H3/H4

Version

  • ids-enterprise: 4.20.0

Platform

  • Browser: Chrome / Safari
@tmcconechy tmcconechy added [2] Velocity rating (Fibonacci) priority: trival Least important issues type: bug 🐛 labels Aug 22, 2019
@tmcconechy
Copy link
Member

Probably have to remove the button/number markup first and then turn it into a H3. Would make for a wierd H3 text. Probably not the straight forward

@tmcconechy tmcconechy added [5] Velocity rating (Fibonacci) and removed [2] Velocity rating (Fibonacci) labels Aug 22, 2019
@volante007
Copy link
Author

Yeah, in IE11/Edge, it transforms into h3/h4. But as you say, works fine if removing list styling first :)

@tmcconechy
Copy link
Member

tmcconechy commented Aug 22, 2019 •
edited

Actually maybe thats an answer - if bullet or number list, call removeMarkup (like the button does) then apply H3, H4

@EdwardCoyle EdwardCoyle added this to To do in Enterprise 4.25.x (December 2019) Sprint via automation Nov 18, 2019
@EdwardCoyle EdwardCoyle mentioned this issue Nov 18, 2019
Closed
@EdwardCoyle EdwardCoyle self-assigned this Dec 6, 2019
@tmcconechy tmcconechy reopened this Jan 27, 2020
@tmcconechy tmcconechy added this to To do in Enterprise 4.28.x (April 2020) Sprint via automation Jan 27, 2020
@tmcconechy tmcconechy added the focus: editor Main focus is Editor label Mar 5, 2020
@tmcconechy tmcconechy added this to To do in Enterprise 4.27.x (March 2020) Sprint via automation Mar 9, 2020
@tmcconechy tmcconechy moved this from To do to In progress in Enterprise 4.27.x (March 2020) Sprint Mar 12, 2020
@tmcconechy tmcconechy assigned tmcconechy and unassigned EdwardCoyle Mar 12, 2020
@tmcconechy tmcconechy mentioned this issue Mar 17, 2020
Merged
2 tasks
@tmcconechy tmcconechy moved this from In progress to Pending Review in Enterprise 4.27.x (March 2020) Sprint Mar 17, 2020
@tmcconechy tmcconechy moved this from Pending Review to Ready for QA (beta) in Enterprise 4.27.x (March 2020) Sprint Mar 23, 2020
@CindyMercadoReyes
Copy link
Collaborator

This issue is now resolved.

@CindyMercadoReyes CindyMercadoReyes moved this from Ready for QA (beta) to Ready for QA (rc) in Enterprise 4.27.x (March 2020) Sprint Mar 24, 2020
@CindyMercadoReyes CindyMercadoReyes moved this from Ready for QA (rc) to Done in Enterprise 4.27.x (March 2020) Sprint Mar 24, 2020
@tmcconechy tmcconechy added the team: homepages Issues for the homepages team label Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmcconechy tmcconechy

Labels
focus: editor Main focus is Editor priority: trival Least important issues team: homepages Issues for the homepages team type: bug 🐛 [5] Velocity rating (Fibonacci)
Projects
No open projects
Enterprise 4.27.x (March 2020) Sprint
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

3594 - Fix Editor Issues infor-design/enterprise
4 participants
@tmcconechy @volante007 @EdwardCoyle @CindyMercadoReyes