Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datagrid: Use position sticky for frozen header #2825

Closed
3 tasks done
tmcconechy opened this issue Sep 23, 2019 · 4 comments · Fixed by #3224
Closed
3 tasks done

Datagrid: Use position sticky for frozen header #2825

tmcconechy opened this issue Sep 23, 2019 · 4 comments · Fixed by #3224
Assignees
Labels
focus: datagrid Main focus is Datagrid team: landmark For Landmark issues type: enhancement ✨ [5] Velocity rating (Fibonacci)

Comments

@tmcconechy
Copy link
Member

tmcconechy commented Sep 23, 2019

Is your feature request related to a problem? Please describe.

Working on weekview position: sticky worked out well. See if i can use this on datagrid as well. This will help with accessibility and prevent mismatched columns.

Describe the solution you'd like

  • Remove the use of two tables for sticky header
  • Make sure we dont need to break table layouts
  • Test all column width settings

Describe alternatives you've considered
Keep current solution

Additional context
https://codepen.io/chriscoyier/pen/PrJdxb
http://localhost:4000/components/week-view/example-index.html (currently on a branch)

@tmcconechy tmcconechy self-assigned this Sep 23, 2019
@tmcconechy
Copy link
Member Author

Relates to #1818 and #425

@tmcconechy tmcconechy added [5] Velocity rating (Fibonacci) focus: datagrid Main focus is Datagrid type: enhancement ✨ labels Sep 23, 2019
@tmcconechy tmcconechy added this to To do in Enterprise 4.23.x (October 2019) Sprint via automation Sep 23, 2019
@tmcconechy tmcconechy moved this from To do to In progress in Enterprise 4.23.x (October 2019) Sprint Oct 18, 2019
@tmcconechy tmcconechy changed the title Datagrid: Explore position sticky for frozen header Datagrid: Use position sticky for frozen header Nov 7, 2019
@lipetzan lipetzan added the team: landmark For Landmark issues label Nov 21, 2019
@tmcconechy tmcconechy moved this from In progress to Ready for QA (beta) in Enterprise 4.24.x (November 2019) Sprint (NG 6.3) Dec 11, 2019
@brianjuan brianjuan moved this from Ready for QA (beta) to Failed QA (beta) in Enterprise 4.24.x (November 2019) Sprint (NG 6.3) Dec 16, 2019
@tmcconechy
Copy link
Member Author

I looked at this as well as it was mentioned on the PR but could not figure out why. This would be nice to fix but is not required as its a problem only on some layouts.

Since this is already raised as a second issue lets just deal with it there #3251

Unfailing the issue

@tmcconechy tmcconechy moved this from Failed QA (beta) to Done in Enterprise 4.24.x (November 2019) Sprint (NG 6.3) Dec 16, 2019
@brianjuan
Copy link

Noted on this @tmcconechy , will track the issues found on #3251 . Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: datagrid Main focus is Datagrid team: landmark For Landmark issues type: enhancement ✨ [5] Velocity rating (Fibonacci)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants